[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debian-devel:11641] Re: NMU release of jgroff 1.15+ja-3.1 uploaded (Re: Re: Installed man-db 2.3.10-70 (source i386))



Hi!

> In <20000214153928.C627@none>,
>  at Date: Mon, 14 Feb 2000 15:39:28 +0200,
>   on Subject: Re: NMU release of jgroff 1.15+ja-3.1 uploaded (Re: [debian-devel:11574] Re: Installed man-db 2.3.10-70 (source i386)),
>    Fabrizio Polacco <fab@xxxxxxxx> writes:
> 
> fab> > fab> Right now I'm uploading groff_1.15-3.ja.1_i386.deb into experimental.
> fab> > fab> It's the 1.15-3 in frozen plus the patch, nothing else.
> fab> > 
> fab> > I visited experimental, but can not find that. 
> fab> > Can you show me the URI ?
> fab> 
> fab> Still in Incoming (due to a Reject I just corrected).

I got it from experimental, and tested.

 "LANG=ja man ls" and "LANG=C man ls" seem to be displayed correctly.
And "sgml2txt -l ja" (which is included in sgml-tools package, and
use the feature of jgroff: -Tnippon) seems to work well.

I tried to build it locally, and check it with "lintian -i".

It warns about

W: groff source: patch-failure-file-in-diff Makefile.in.orig
W: groff source: patch-failure-file-in-diff devps/Makefile.sub.orig
W: groff source: patch-failure-file-in-diff grops/ps.cc.orig
W: groff source: patch-failure-file-in-diff troff/input.cc.orig

and .deb does not have the information about "Section:" and "Priority:".

I think you should add "-isp" option to dpkg-gencontrol in debian/rules file,
and remove these extra .orig files.

BTW, in article <87vh3v62o8.wl@xxxxxxxxxxxxxxx>,
  at Sat, 12 Feb 2000 02:59:19 +0900,
 Fumitoshi UKAI <ukai@debian.or.jp> writes:

> * 1.15-3.ja.1 has same bug as Bug#47800.

I check this with "gunzip < /usr/share/man/ja/man1/ls.1.gz | groff -TX75 -man"
and the result is not correct.

>   In debian/rules build,
> 
> 	cd xditview; $(MAKE) depend;  \
>         $(MAKE) CC="$(CC)" CCFLAGS="$(CFLAGS)" CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS) -lc" 
> 
>   So, DEFINES=".... -DNIPPON" will be overrided CCFLAGS/CFALGS supplied by
>   this command line.  I think it should be, for example,
> 
> 	cd xditview; $(MAKE) depend;  \
>         $(MAKE) CC="$(CC)" CXXEXTRA_DEFINES="$(CCFLAGS)" EXTRA_DEFINES="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS) -lc" 
> 
>   or need not pass CCFLAGS and CFLAGS.

Another workaround is add "-DNIPPON" to CFLAGS in debian/rules, I think.

--- build-exp/groff-1.15/debian/rules	Wed Feb 16 16:25:51 2000
+++ chk-build-exp/groff-1.15/debian/rules	Wed Feb 16 16:47:15 2000
@@ -3,7 +3,7 @@
 # rules to debianize groff
 
 CC = gcc
-CFLAGS = -O2
+CFLAGS = -O2 -DNIPPON=1
 LDFLAGS = -s
 
 package = groff
@@ -103,7 +103,7 @@
 	install -g root -m 755 -o root debian/postrm debian/tmp/DEBIAN
 	#
 	dpkg-shlibdeps $(package)/$(package) -dSuggests xditview/gxditview
-	dpkg-gencontrol
+	dpkg-gencontrol -isp
 	chown -R root.root debian/tmp
 	chmod -R g-ws debian/tmp
 	dpkg --build debian/tmp ..

This "setting -DNIPPON=1 at CFLAGS in debian/rules" is redundant
for other directories than xditview, but the result of this
can display "gunzip < /usr/share/man/ja/man1/ls.1.gz | groff -TX75 -man"
correctly. (although not so beautifull, IMHO) I have checked this
by locally built package using the patch above.

It enables "gunzip < /usr/share/man/ja/man1/ls.1.gz | groff -Tps -X -man"
also, while this does not work without "-DNIPPON" for xditview.

I have some more reuest. Current manpages-ja has "Depends: jgroff" line.
So if you upload the new groff with "Conflicts/Replaces: jgroff" into
unstable, please add "Provides: jgroff" for smooth upgrade.

When your new groff is installed with the capability of jgroff,
then we can delete that "Depends" line from manpages-ja.

 (The maintainer of manpages-ja, Keita Maehara, is one of our JP member.
  And he will happily do this when he can do it safely, I think.)  

> * jgroff patch will select dvi device at configure time.
>   I think it's better that we have two type of dvi device, for example,
>   dvi (modified for NTT-JTeX) and dvi-ascii (for ASCII pTeX).

Maybe. I don't know about this well. I have checked that I got the dvi file by
 "gunzip < /usr/share/man/ja/man1/ls.1.gz | groff -Tdvi -man >/tmp/lsman.dvi"
and this /tmp/lsman.dvi can be displayed correctly by the command "xdvi-ja.small"
(which is included in xdvik-ja package).

> * eqn/eqn.cc and eqn/eqn.tab.h are autogenerated from eqn/eqn.y 
>   so you can remove it in debian/rules clean

Maybe. I didn't notice this before reading the ukai's mail.

> > It should be quite the same as the other package, I suppose, but we can
> > ask people in debian-i18l to use it instead of frozen groff, and report
> > problems in their environment.
>
> I agree, so I'll send this to debian-i18n.
> Please test groff 1.15-3.ja.1 in experimental and report whether it works
> for your environment.

I hope that we can get the merged groff in Debian at least soon.
(Merged at the upstream is better, of course.) So I send this
to debian-i18n as well.

Sincerely.

-- 
  Taketoshi Sano: <sano@debian.org>,<sano@debian.or.jp>,<kgh12351@xxxxxxxxxxx>